-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume scroll notification #13
Conversation
Enable to nest mulitple ScrollShadow without the inner one interfering with the outer one
Hi @pixelshot91, I tried to reproduce your scenario of a ScrollShadow inside another ScrollShadow. However the behavior with and without your change for me is the same. Could you tell me which differences you found? |
I made two video showcasing the bug fix. after_fix.webm The code used to create the video is available here: |
Sorry, I tried the two scroll shadow in the same direction and I did't see any problem. |
I added the test and a 'flutter test' step in the workflow |
Is ok for you ? @RichiB20 |
Yes it's ok, as soon as @rickypid is able he will accept the PR. |
Hi @pixelshot91, Sorry for the delay but it's a very intense period, Thanks to you and @RichiB20 for the contribution. |
…rferences has been fixed. See rickypid/flutter_scroll_shadow#13
…rferences has been fixed. See rickypid/flutter_scroll_shadow#13
Enable to nest mulitple ScrollShadow without the inner one interfering with the outer one